Improve change-version script #33148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XhmikosR
commented
Feb 19, 2021
XhmikosR
force-pushed
the
main-xmr-change-version-script
branch
from
28b2719
to
7cf62f7
Compare
mdo
approved these changes
Mar 11, 2021
GeoSot
reviewed
Mar 11, 2021
XhmikosR
force-pushed
the
main-xmr-change-version-script
branch
3 times, most recently
from
e7c47bc
to
589e025
Compare
* switch to async/await * remove shelljs * switch to globby; supports .gitignore out of the box * don't write any files to the disk if they are indentical * add two more cmd switches: --dry and --verbose * strip leading "v" from version arguments so that we don't end up with duplicate `v`s
XhmikosR
force-pushed
the
main-xmr-change-version-script
branch
from
589e025
to
42c3a00
Compare
XhmikosR
added a commit
that referenced
this pull request
Mar 11, 2021
* switch to async/await * remove shelljs * switch to globby; supports .gitignore out of the box * don't write any files to the disk if they are indentical * add two more cmd switches: --dry and --verbose * strip leading "v" from version arguments so that we don't end up with duplicate `v`s
XhmikosR
added a commit
that referenced
this pull request
Mar 15, 2021
* switch to async/await * remove shelljs * switch to globby; supports .gitignore out of the box * don't write any files to the disk if they are indentical * add two more cmd switches: --dry and --verbose * strip leading "v" from version arguments so that we don't end up with duplicate `v`s
XhmikosR
added a commit
that referenced
this pull request
Mar 23, 2021
* switch to async/await * remove shelljs * switch to globby; supports .gitignore out of the box * don't write any files to the disk if they are indentical * add two more cmd switches: --dry and --verbose * strip leading "v" from version arguments so that we don't end up with duplicate `v`s
XhmikosR
added a commit
that referenced
this pull request
Apr 5, 2021
* switch to async/await * remove shelljs * switch to globby; supports .gitignore out of the box * don't write any files to the disk if they are indentical * add two more cmd switches: --dry and --verbose * strip leading "v" from version arguments so that we don't end up with duplicate `v`s
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have this patch around for some time now.
Using globby is a little slower than on main, but we get to simplify the script a lot.
So, apart from adding a couple of command line options, and not writing the files back to disk if they are changed, this changes the logic of the script: we only replace the version in the files we have in the glob and not all file types.
I could split the patches but I thought it might make sense to make all the changes in the same PR.
Please check the individual commits in case I missed something.
If merged, I will backport it to v4-dev.