Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clear duplicated class border-0 #32925

Merged
merged 5 commits into from
Feb 16, 2021
Merged

Clear duplicated class border-0 #32925

merged 5 commits into from
Feb 16, 2021
+7 −4

Conversation

k-utsumi
Copy link
Contributor

@k-utsumi k-utsumi commented Jan 29, 2021 •
edited
Loading

dist/css/bootstrap-utilities.css

@k-utsumi k-utsumi requested a review from a team as a code owner January 29, 2021 04:12
@ffoodd
Copy link
Member

ffoodd commented Jan 29, 2021

Nice catch, thanks!

Wouldn't it be better to drop the relevant entry in _utilities.scss (L77) instead? @mdo any opinion?

@k-utsumi
Copy link
Contributor Author

Wouldn't it be better to drop the relevant entry in _utilities.scss (L77) instead?

I think that's no good 🙈

In the current dist CSS order,
make it impossible to set some directions border with clearing the components border.

@ffoodd
Copy link
Member

ffoodd commented Jan 29, 2021 •
edited
Loading

For the record, this is somehow unrelevant: if you want to clean some borders only (and not all), do not use .border-0 which means drop all borders. Use .border-top-0 and so on.

However I prefer that .border-0 matches border: 0; instead of border-width: 0; so I'd stick to your suggestion. :)

@XhmikosR XhmikosR requested a review from mdo January 29, 2021 19:45
mdo
mdo reviewed Feb 12, 2021
View reviewed changes
Copy link
Member

@mdo mdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs a migration guide entry. @k-utsumi Care to take a pass at that?

@k-utsumi
Copy link
Contributor Author

I don't know what the migration guide entry is, and I'm not very good at English 😂
Please write that, or I'll try to write if show me some examples 🙋‍♂️

@ffoodd
Copy link
Member

ffoodd commented Feb 15, 2021

@k-utsumi The migration guide is migration.md in site/content/docs/5.0/, you may simply mentionned something like:

Dropped the 0 entry in $border-widths map to remove duplicated utilities.

@k-utsumi
Copy link
Contributor Author

@ffoodd Thanks, maybe I understood🙌

@XhmikosR XhmikosR requested a review from mdo February 15, 2021 12:31
@k-utsumi
Copy link
Contributor Author

Thanks😊

@XhmikosR XhmikosR merged commit 4d19e0e into twbs:main Feb 16, 2021
@XhmikosR XhmikosR changed the title ♻️ Clear duplicated class border-0 Clear duplicated class border-0 Feb 16, 2021
@k-utsumi k-utsumi deleted the patch-1 branch February 16, 2021 06:08
@ffoodd ffoodd mentioned this pull request Feb 22, 2021
Merged
This was referenced Jul 12, 2024
Open
Open
Open
Open
Open
This was referenced Jul 27, 2024
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ffoodd ffoodd ffoodd approved these changes

@mdo mdo mdo approved these changes

Assignees
No one assigned
Labels
confirmed css needs migration notes v5
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@k-utsumi @ffoodd @mdo @XhmikosR