Add function type for popperConfig option
#32882
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rohit2sharma95 can you please add a test? |
rohit2sharma95
force-pushed
the
rohit/main/popper-config-function
branch
2 times, most recently
from
8f2b842
to
95b9bf6
Compare
rohit2sharma95
force-pushed
the
rohit/main/popper-config-function
branch
2 times, most recently
from
094dd50
to
0af13f6
Compare
XhmikosR
reviewed
Feb 8, 2021
| <td><code>null</code></td> | ||
| <td>To change Bootstrap's default Popper config, see <a href="https://popper.js.org/docs/v2/constructors/#options">Popper's configuration</a></td> | ||
| <td>To change Bootstrap's default Popper config, see <a href="https://popper.js.org/docs/v2/constructors/#options">Popper's configuration</a>. If you pass the <code>popperConfig</code> as a function, it accepts the Bootstrap's default Popper config as an argument, you need to return the configuration from this function as an object.</td> |
There was a problem hiding this comment.
I'm not sure this is self-explanatory. Can we maybe reword this and all the instances in this PR? Perhaps with an example?
There was a problem hiding this comment.
Agreed on wording here, needs a rev. After that should be good to go from my perspective.
XhmikosR
force-pushed
the
rohit/main/popper-config-function
branch
from
0af13f6
to
41cf258
Compare
rohit2sharma95
force-pushed
the
rohit/main/popper-config-function
branch
from
18d23c9
to
177c880
Compare
|
@mdo please check the wording and maybe if the example is easy to grasp. It might need some further tweaking :) |
mdo
approved these changes
Feb 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since shallow merge is used to merge
popperConfigpassed by the user for popper's config, this overrides themodifiersproperty instead of merging the array.So creating
popperConfiga function and then passing the default configuration as an argument gives users the ability to use the default configuration and merge it with their configuration. Keeping the previous typeobjectin the supported types since removing it would be a breaking change.Ref: #32443 (comment)
@XhmikosR Let me know if it is a good idea 🙂