-
-
Notifications
You must be signed in to change notification settings - Fork 79k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Popper preventOverflow boundary config #32845
Conversation
@kyletsang do we have any issue about this? I don't suppose this issue could be related to any of the other Popper issues we have in v5? |
@XhmikosR, currently no issue reported. I was reviewing the code to see if there's any new modifiers I needed to port over to This could potentially cause issues due to incorrect usage of |
@kyletsang do you think you could add some tests about this? |
Ugh, I think I'm going to need some assistance on this. I can't seem to come up with a demo that shows any difference when setting an incorrect |
Unfortunately, I have no idea how to test for this. We should have a test to make sure we don't hit this again, but if we can't have a test, I guess we could make an exception here. |
@rohit2sharma95 LGTY? |
Currently, the boundary config is being assigned to the wrong var (
rootBoundary
) in the popper config. It should be assigned to theboundary
var in popper's config.Ref: https://popper.js.org/docs/v2/utils/detect-overflow/#boundary