Skip to content

Backport #32037 #32833

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 19, 2021
Merged

Backport #32037 #32833

merged 2 commits into from
Jan 19, 2021

Conversation

XhmikosR
Copy link
Member

@XhmikosR XhmikosR commented Jan 19, 2021 •
edited
Loading

Add .navbar-nav-scroll for vertical scrolling of navbar content

Preview: https://deploy-preview-32833--twbs-bootstrap.netlify.app/docs/4.5/components/navbar/#scrolling

TODO:

  • Remove CSS var

@XhmikosR XhmikosR requested a review from mdo January 19, 2021 05:42
XhmikosR and others added 2 commits January 19, 2021 07:55
@XhmikosR
Backport #32037
1544125 
Add `.navbar-nav-scroll` for vertical scrolling of navbar content
@mdo @XhmikosR
drop the css var for a Sass css
2b6aa06
@XhmikosR XhmikosR marked this pull request as ready for review January 19, 2021 05:58
@XhmikosR XhmikosR requested a review from a team as a code owner January 19, 2021 05:58
@XhmikosR XhmikosR merged commit 9d87bd7 into v4-dev Jan 19, 2021
@XhmikosR XhmikosR deleted the v4-dev-bp branch January 19, 2021 06:18
This was referenced Mar 8, 2021
Closed
Merged
Merged
Merged
@dependabot dependabot bot mentioned this pull request Mar 18, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdo mdo mdo approved these changes

Assignees
No one assigned
Labels
css v4
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@XhmikosR @mdo