Docs v4: Sass implementation and rounding precision #32791
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XhmikosR
reviewed
Jan 14, 2021
|
Is this slated for v4.6.0 or will it have to wait until v4.6.1? |
… about the Sass compiler used and the minimum rounding precision we recommend with it.
voltaek
force-pushed
the
v4-docs-sass-compiler-precision
branch
from
f626c8b
to
42310bc
Compare
|
Rebased against |
mdo
approved these changes
Jan 17, 2021
This was referenced Mar 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@XhmikosR Here is the backport you requested in #32512.
This makes changes similar to those made to the v5 docs to update and clarify the Sass compiler used and the minimum rounding precision we recommend with it. The details added are linked to from several places now instead of bits of the info being spread throughout the docs.
I added some notes about Node Sass being deprecated and how Dart Sass should be a mostly drop in replacement if the user would need support for newer Sass features or CSS standards. It's still made clear that we build Bootstrap v4 with Node Sass, so I think this is a good balance of telling them it's still alright to compile with it while also giving them options if they need newer features.