Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump linkinator from 2.11.2 to 2.13.0 #32678

Closed
wants to merge 2 commits into from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jan 5, 2021

Bumps linkinator from 2.11.2 to 2.13.0.

Release notes

Sourced from linkinator's releases.

v2.13.0

2.13.0 (2021-01-04)

Features

v2.12.2

2.12.2 (2020-12-30)

Bug Fixes

v2.12.1

2.12.1 (2020-12-29)

Bug Fixes

  • support commas and spaces in linksToSkip (#226) (a7d8625)

v2.12.0

2.12.0 (2020-12-29)

Features

Commits

Dependabot compatibility score

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@XhmikosR
Copy link
Member

XhmikosR commented Jan 5, 2021

@JustinBeckwith it seems there's a regression in v2.13.0 :)

@XhmikosR XhmikosR closed this Jan 5, 2021
@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Jan 5, 2021

OK, I won't notify you again about this release, but will get in touch when a new version is available.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@XhmikosR XhmikosR deleted the dependabot/npm_and_yarn/linkinator-2.13.0 branch January 5, 2021 13:07
@JustinBeckwith
Copy link

Entirely possible, spent some holiday break time adding features and such :) Is it possible this is an actual 404 though? Reading the logs, I'm seeing this:


🏊‍♂️ crawling _gh_pages
[404] http://localhost:5712/docs/5.0/
http://localhost:5712/docs/5.0/getting-started/introduction/
  [404] http://localhost:5712/docs/5.0/
ERROR: Detected 1 broken links. Scanned 688 links in 2.774 seconds.

If that link is really working, happy to dig in.

@XhmikosR
Copy link
Member

XhmikosR commented Jan 5, 2021

@JustinBeckwith yup, the links do exist:

It's just the first is supposed to do a client-side redirect, which we do in more places. But this only just fails.

Thanks for looking into it and happy new year!

@JustinBeckwith
Copy link

Huh - if this is a client-side redirect-only, those have never worked (as far as I know). We just do a fetch of the underlying link to check if it exists; no script or meta redirects get executed.

@XhmikosR
Copy link
Member

XhmikosR commented Jan 5, 2021

But still, what we have works for us until v2.11.2. Something is off in v2.13.0 as you can see from the CI :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants