Dropdown — Emit events on the .dropdown-toggle button
#32625
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It does not change/break the previous behavior though @XhmikosR |
|
I haven't looked closely, but if it's not a breaking change please finish the patch so that we ship it. I guess we could think about backporting it if it's really a safe patch. |
rohit2sharma95
force-pushed
the
rohit/main/dropdown-events
branch
from
4f57b51
to
358d29f
Compare
|
I believe that the |
rohit2sharma95
commented
Jan 14, 2021
rohit2sharma95
force-pushed
the
rohit/main/dropdown-events
branch
from
358d29f
to
55416f1
Compare
Emit the events on `.dropdown-toggle` button and then bubble up
rohit2sharma95
force-pushed
the
rohit/main/dropdown-events
branch
from
55416f1
to
cc45999
Compare
|
Does this also fix #30882 ? |
mdo
approved these changes
Feb 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Emit all events on the
.dropdown-togglebutton instead of.dropdown. Now seems thatrelatedTargetis not needed because the toggling element is available in the main event's target. @XhmikosRCloses #31935