Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: work around Toast CSS conflict with utils #32620

Merged
merged 3 commits into from
Jan 15, 2021

Conversation

sijusamson
Copy link
Contributor

@sijusamson sijusamson commented Dec 27, 2020

Fixes #32350.

Copy link
Member

@mdo mdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks!

@XhmikosR
Copy link
Member

XhmikosR commented Jan 8, 2021

My only objection is that maybe we shouldn't use this extra div in the snippet? It only affect our docs, right? If so, we should split the blocks.

@XhmikosR XhmikosR changed the title Toast CSS conflict resolved docs: work around Toast CSS conflict with utils Jan 8, 2021
@sijusamson
Copy link
Contributor Author

sijusamson commented Jan 11, 2021

My only objection is that maybe we shouldn't use this extra div in the snippet? It only affect our docs, right? If so, we should split the blocks.

I guess we have two other options to resolve it.

  1. To add !important in display.
  2. May be we can add display: flex in toast class itself, but not sure what all impact will it have?

@XhmikosR Do you want me to proceed with these solutions or do you suggest something else?

@mdo
Copy link
Member

mdo commented Jan 11, 2021

I'm fine with the extra div. I don't think we need to make any changes to that as it leaves the core component intact and encourages folks to customize everything within the toast.

@mdo mdo merged commit 9bec37a into twbs:main Jan 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Toasts: .hide CSS can conflict with utilities
3 participants