Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scrollspy - Remove unnecessary event argument #32603

Merged
merged 2 commits into from
Jan 7, 2021
Merged

Scrollspy - Remove unnecessary event argument #32603

merged 2 commits into from
Jan 7, 2021

Conversation

rohit2sharma95
Copy link
Collaborator

The event argument in _process method seems unnecessary here:

bootstrap/js/src/scrollspy.js

Line 79 in bcf6916

EventHandler.on(this._scrollElement, EVENT_SCROLL, event => this._process(event))

@rohit2sharma95 rohit2sharma95 requested a review from a team as a code owner December 23, 2020 17:52
@XhmikosR XhmikosR changed the title Scrollspy — Remove unnecessary event argument Scrollspy - Remove unnecessary event argument Jan 7, 2021
@XhmikosR XhmikosR merged commit 3c934dd into main Jan 7, 2021
@XhmikosR XhmikosR deleted the rohit/main/scrollspy-process branch January 7, 2021 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XhmikosR XhmikosR XhmikosR approved these changes

@mdo mdo mdo approved these changes

Assignees
No one assigned
Labels
js v5
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rohit2sharma95 @mdo @XhmikosR