Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tooltip - check if tip and its parent node exist in dispose method #32420

Merged
merged 1 commit into from
Dec 10, 2020
Merged

Tooltip - check if tip and its parent node exist in dispose method #32420

merged 1 commit into from
Dec 10, 2020

Conversation

rohit2sharma95
Copy link
Collaborator

@rohit2sharma95 rohit2sharma95 commented Dec 10, 2020 •
edited by XhmikosR
Loading

Fixes #31658

@rohit2sharma95 rohit2sharma95 requested a review from a team as a code owner December 10, 2020 17:52
@XhmikosR XhmikosR changed the title Tooltip — check if tip and it's parent node exist in dispose method Tooltip - check if tip and its parent node exist in dispose method Dec 10, 2020
XhmikosR
XhmikosR approved these changes Dec 10, 2020
View reviewed changes
Copy link
Member

@XhmikosR XhmikosR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works beautifully, thanks!

@XhmikosR XhmikosR merged commit 4535b09 into main Dec 10, 2020
@XhmikosR XhmikosR deleted the rohit-tooltip-dipose-v5 branch December 10, 2020 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XhmikosR XhmikosR XhmikosR approved these changes

Assignees
No one assigned
Labels
js v5
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error 'this.tip.parentNode is null' when disposing of Tooltip.
2 participants
@rohit2sharma95 @XhmikosR