Tweak .form-select padding #32419
Merged
Tweak .form-select padding #32419
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Second commit here makes some slightly bigger changes to simplify the padding. Unsure if it's a possible breaking change though, so would love feedback from @twbs/css-review.
|
|
The complex |
MartijnCuppens
approved these changes
Dec 24, 2020
sijusamson
pushed a commit
to sijusamson/bootstrap
that referenced
this pull request
Jan 4, 2021
* Tweak .form-select padding * Simplify the padding entirely Co-authored-by: XhmikosR <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #32356 and fixes #32188. Still might need some work, and I might be able to simplify things further.