Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Popper fallback behaviour #32405

Merged
merged 1 commit into from
Dec 9, 2020
Merged

Add Popper fallback behaviour #32405

merged 1 commit into from
Dec 9, 2020

Conversation

MartijnCuppens
Copy link
Member

@MartijnCuppens MartijnCuppens commented Dec 9, 2020 •
edited
Loading

@MartijnCuppens MartijnCuppens requested a review from a team as a code owner December 9, 2020 18:23
@mdo mdo merged commit f132400 into main Dec 9, 2020
@mdo mdo deleted the main-mc-popper-fallback-fix branch December 9, 2020 21:34
@XhmikosR
Copy link
Member

XhmikosR commented Dec 9, 2020

@mdo this needed docs. Also makes me wonder why we needed this since @Johann-S added this as optional (null).

@XhmikosR
Copy link
Member

XhmikosR commented Dec 9, 2020

@MartijnCuppens can you please update the docs tomorrow?

@XhmikosR XhmikosR mentioned this pull request Dec 10, 2020
Closed
4 tasks
@rohit2sharma95 rohit2sharma95 mentioned this pull request Dec 11, 2020
Merged
@rohit2sharma95 rohit2sharma95 mentioned this pull request Dec 29, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdo mdo mdo approved these changes

Assignees
No one assigned
Labels
js no-backport-to-v4 v5
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Popover overflows container (regression)
3 participants
@MartijnCuppens @XhmikosR @mdo