Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Utility API, RFS option: Only generate responsive classes when needed #32397

Merged
merged 2 commits into from
Dec 9, 2020

Conversation

MartijnCuppens
Copy link
Member

I bumped into these classes which shouldn't be generated when responsive isn't set true:

bootstrap/dist/css/bootstrap.css

Lines 10631 to 10673 in b1290ff

.fs-sm-2 {
font-size: 2rem !important;
}
.fs-sm-3 {
font-size: 1.75rem !important;
}
.fs-sm-4 {
font-size: 1.5rem !important;
}
.fs-md-1 {
font-size: 2.5rem !important;
}
.fs-md-2 {
font-size: 2rem !important;
}
.fs-md-3 {
font-size: 1.75rem !important;
}
.fs-md-4 {
font-size: 1.5rem !important;
}
.fs-lg-1 {
font-size: 2.5rem !important;
}
.fs-lg-2 {
font-size: 2rem !important;
}
.fs-lg-3 {
font-size: 1.75rem !important;
}
.fs-lg-4 {
font-size: 1.5rem !important;
}

@MartijnCuppens MartijnCuppens requested a review from a team as a code owner December 9, 2020 09:22
@MartijnCuppens MartijnCuppens changed the title RFS: Only generate responsive classes when needed Utility API, RFS option: Only generate responsive classes when needed Dec 9, 2020
@XhmikosR
Copy link
Member

XhmikosR commented Dec 9, 2020

@MartijnCuppens Is this a regression from the RTL PR?

@mdo
Copy link
Member

mdo commented Dec 9, 2020

Is this a regression from the RTL PR?

I don't believe so—this looks like a mix up from rfs and responsive options maybe.

@XhmikosR XhmikosR merged commit 8fed098 into main Dec 9, 2020
@XhmikosR XhmikosR deleted the main-mc-utility-rfs-fix branch December 9, 2020 21:49
@XhmikosR XhmikosR mentioned this pull request Feb 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants