Add helpers to utilities bundle #32324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjansing
force-pushed
the
add-helpers-to-utilities-bundle
branch
from
152d31b
to
1194c75
Compare
Adds currently missing utilities classes which are located in scss/helpers to boostrap-utilities deliverable.
mjansing
force-pushed
the
add-helpers-to-utilities-bundle
branch
from
1194c75
to
6bde754
Compare
mdo
approved these changes
Dec 9, 2020
|
Shouldn't it be mentionned in the docs? |
|
@ffoodd like where? It seems utilities are already mentioned in https://getbootstrap.com/docs/5.0/getting-started/contents/#css-files. Feel free to push to this branch if you have any ideas. |
|
Don't really know, maybe we didn't mention helpers anywhere before? It should at least appear in the migration guide since people importing only our utilities in a custom build will now import helpers incidentally, what they might have done explicitly before. |
|
@mjansing can you please take care of the above comment? |
|
@XhmikosR I added a migration note. |
ffoodd
previously requested changes
Dec 16, 2020
MartijnCuppens
approved these changes
Dec 16, 2020
ffoodd
approved these changes
Dec 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bootstrap bundles utility classes in a dedicated bootstrap-utilities deliverable (
bootstrap-utilities.css) but the deliverable does not contain all utilities mentioned in the documentation (e.g..sticky-top,.stretched-linkor.text-truncate). These missing utilities are located inscss/helpers/and currently not part of it. This PR adds them.