build-plugins: build Base component too #32313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rohit2sharma95
approved these changes
Dec 2, 2020
|
We should clean up this script later. I don't see why we need so much duplication. |
XhmikosR
force-pushed
the
main-xmr-build-base
branch
from
ee0c785
to
a11c552
Compare
|
So, I'm not sure about this. It will add a new dependency for each component. On the other hand, it will reduce duplication in each individual plugin dist file. If we plan to move more stuff to the Base component, maybe it makes sense to build it separately. Oh, and we need to document this somehow. |
XhmikosR
added a commit
that referenced
this pull request
Feb 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure about this, but I noticed that currently the base plugin is inlined in each plugin's dist file.