Ability to add custom class in tooltip/popover #32217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rohit2sharma95
commented
Nov 20, 2020
rohit2sharma95
force-pushed
the
toolip-custom-class
branch
from
89d086e
to
eff6db0
Compare
- Add unit tests to check either customClass is being added or not - Update the show method to add mutiple class provided (space separated)
Johann-S
approved these changes
Nov 25, 2020
XhmikosR
added a commit
that referenced
this pull request
Nov 25, 2020
Remove unnecessary `_getCustomClass` method. `customClass` will be in the configuration already, even if it is provided in the data attributes, and jQuery's [`addClass()`](https://api.jquery.com/addclass/) method will handle it, either `this.config.customClass` is a function or a class name (even if it is a blank string). Co-authored-by: XhmikosR <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Porting of #31834 to main.
Fixes #19415