Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manually optimize SVGs #32187

Merged
merged 4 commits into from
Nov 19, 2020
Merged

Manually optimize SVGs #32187

merged 4 commits into from
Nov 19, 2020

Conversation

Copy link
Member

@ffoodd ffoodd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch 👍

@XhmikosR
Copy link
Member

Can you maybe change any IDs to be more specific? Usually it's not an issue, but I'm not sure if it's OK when including multiple SVGs and we end up with the same IDs. If it doesn't change anything, just ignore this comment :)

PS. I'd like @mdo's approval just so that we are safe since he created these in the first place.

@XhmikosR
Copy link
Member

BTW after this lands, we need to update any icons in the blog and the icons repo.

@XhmikosR XhmikosR requested a review from mdo November 18, 2020 12:30
@mdo
Copy link
Member

mdo commented Nov 18, 2020

The after doesn't look right to me on latest iOS.

image

@MartijnCuppens
Copy link
Member Author

Pushed the fix for iOS:
image

@mdo
Copy link
Member

mdo commented Nov 18, 2020

Ah, I see what's changed now. The extra B was intentional to give it a 1px white stroke, while the rest of the B had a gradient. Just an extra bit of styling. Thoughts on keeping/cutting?

@MartijnCuppens
Copy link
Member Author

MartijnCuppens commented Nov 18, 2020

The extra B was intentional to give it a 1px white stroke

I've just added the stroke, it's barely visible, but I can see it a little bit on 2x zoom:

image

image

@XhmikosR XhmikosR added docs and removed meta labels Nov 18, 2020
@XhmikosR
Copy link
Member

@MartijnCuppens feel free to merge when squashing; not sure what the commit message should be after your changes :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants