-
-
Notifications
You must be signed in to change notification settings - Fork 78.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Manually optimize SVGs #32187
Manually optimize SVGs #32187
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice catch 👍
Can you maybe change any IDs to be more specific? Usually it's not an issue, but I'm not sure if it's OK when including multiple SVGs and we end up with the same IDs. If it doesn't change anything, just ignore this comment :) PS. I'd like @mdo's approval just so that we are safe since he created these in the first place. |
BTW after this lands, we need to update any icons in the blog and the icons repo. |
Ah, I see what's changed now. The extra B was intentional to give it a 1px white stroke, while the rest of the B had a gradient. Just an extra bit of styling. Thoughts on keeping/cutting? |
@MartijnCuppens feel free to merge when squashing; not sure what the commit message should be after your changes :) |
55ca336
to
04683fa
Compare
fill
,clip-rule
&fill-rule
attributes.Before:
After: