Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

examples: fix .btn-block instances #32177

Merged
merged 4 commits into from
Nov 19, 2020
Merged

examples: fix .btn-block instances #32177

merged 4 commits into from
Nov 19, 2020

Conversation

XhmikosR
Copy link
Member

Regression of #31995

ffoodd
ffoodd approved these changes Nov 17, 2020
View reviewed changes
Copy link
Member

@ffoodd ffoodd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fixes missed cases, however re-reading the initial PR, using .w-100 as a simple replacement for .btn-block isn't mentionned in our docs nor in our migration guide.

Shouldn't it be?

@XhmikosR
Copy link
Member Author

I guess it could, not sure why @mdo didn't mention it, but he might have just missed it :)

@XhmikosR
Copy link
Member Author

BTW not sure if w-100 should be added at the end or not. Let me know if you have a preference.

mdo
mdo approved these changes Nov 17, 2020
View reviewed changes
Copy link
Member

@mdo mdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hadn't mentioned .w-100 because most of the situations I was thinking about were for multiple stacked buttons. Feel free to add something to the Migration docs for our last release.

@XhmikosR
Copy link
Member Author

I'm unsure how to reword the current text, so please have a look @mdo in another PR or push it here :)

@XhmikosR XhmikosR merged commit 7fec0ec into main Nov 19, 2020
@XhmikosR XhmikosR deleted the main-xmr-btn-block-examples branch November 19, 2020 05:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ffoodd ffoodd ffoodd approved these changes

@mdo mdo mdo approved these changes

Assignees
No one assigned
Labels
docs examples v5
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@XhmikosR @mdo @ffoodd