Skip to content

Rename scale-color() function to shift-color() #32149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 13, 2020
Merged

Rename scale-color() function to shift-color() #32149

merged 1 commit into from
Nov 13, 2020

Conversation

mdo
Copy link
Member

@mdo mdo commented Nov 13, 2020

To avoid collision with Sass's own color function, without renaming all our functions, which feels like an unnecessary step this close to our beta release. Alternative to #32107.

@mdo mdo marked this pull request as ready for review November 13, 2020 18:13
@mdo mdo requested a review from a team as a code owner November 13, 2020 18:13
@XhmikosR XhmikosR merged commit 55f2192 into main Nov 13, 2020
@XhmikosR XhmikosR deleted the shift-color branch November 13, 2020 18:51
@XhmikosR XhmikosR changed the title Rename scale-color() function to shift-color() Rename scale-color() function to shift-color() Nov 13, 2020
@ffoodd ffoodd mentioned this pull request Nov 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants