Add note that user-select-all is not supported on IE or Edge Legacy
#32120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… or Edge Legacy Fixes: #32092 I kept the style/formatting of the compatibility issue **bold**, so it matches what is used elsewhere for IE issues, e.g.: https://getbootstrap.com/docs/4.5/utilities/flex/#auto-margins https://getbootstrap.com/docs/4.5/utilities/position/#sticky-top
|
Thanks! @mdo LGTY or do you think we should use a (warning) callout? I think we are better off using a warning callout |
MartijnCuppens
approved these changes
Nov 13, 2020
|
@coliff we can't merge this it seems; you removed your fork at some point :/ |
mdo
reviewed
Nov 13, 2020
| @@ -16,4 +16,6 @@ Change how the content is selected when the user interacts with it. | |||
| {% endcapture %} | |||
| {% include example.html content=example %} | |||
|
|
|||
| **Note: `user-select-all` is not supported on Internet Explorer or Edge Legacy.** | |||
There was a problem hiding this comment.
I'd move this up to be part of Line 10, and make this edit:
Note that Internet Explorer and Legacy Edge have no support for the
allvalue foruser-select, and as such,.user-select-allis not supported by either browser.
There was a problem hiding this comment.
@mdo can you make a PR please? ❤
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #32092
I kept the style/formatting of the compatibility issue bold, so it matches what is used elsewhere for IE issues, e.g.:
https://getbootstrap.com/docs/4.5/utilities/flex/#auto-margins
https://getbootstrap.com/docs/4.5/utilities/position/#sticky-top
I haven't been able to test this change locally by building the docs (don't have Jekyll 4.x installed right now)... but as this is simple change hopefully it should be ok.
Preview: https://deploy-preview-32120--twbs-bootstrap.netlify.app/docs/4.5/utilities/interactions/