Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JS: use more "modern" APIs #32095

Merged
merged 7 commits into from
Nov 14, 2020
Merged

JS: use more "modern" APIs #32095

merged 7 commits into from
Nov 14, 2020

Conversation

XhmikosR
Copy link
Member

@XhmikosR XhmikosR commented Nov 9, 2020 •
edited
Loading

So, I had this branch around since March 2020.

Currently, with our target browsers, I think it's safe to make these changes.

Preview: https://deploy-preview-32095--twbs-bootstrap.netlify.app/

  • Test Safari 10 - EDIT: I tested Safari 10.1 on BrowserStack and seems to work fine.

@XhmikosR XhmikosR marked this pull request as ready for review November 9, 2020 10:14
@XhmikosR XhmikosR requested a review from a team as a code owner November 9, 2020 10:14
Johann-S
Johann-S approved these changes Nov 14, 2020
View reviewed changes
Copy link
Member

@Johann-S Johann-S left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@XhmikosR XhmikosR merged commit 12f5108 into main Nov 14, 2020
@XhmikosR XhmikosR deleted the master-xmr-js-modern-api branch November 14, 2020 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Johann-S Johann-S Johann-S approved these changes

Assignees
No one assigned
Labels
js v5
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@XhmikosR @Johann-S