Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add .gap utilities #32074

Merged
merged 5 commits into from
Nov 8, 2020
Merged

Add .gap utilities #32074

merged 5 commits into from
Nov 8, 2020

Conversation

mdo
Copy link
Member

@mdo mdo commented Nov 6, 2020

Following up on #32066 and the responsive .btn-block classes in #31995. If this is going well, I'm hoping we can add a quick commit here (or another PR) to remove .btn-block and replace it with d-grid and gap utilities.

Screen Shot 2020-11-06 at 12 22 54 PM

Preview: https://deploy-preview-32074--twbs-bootstrap.netlify.app/docs/5.0/utilities/spacing/#gap

@@ -93,3 +95,17 @@ The syntax is nearly the same as the default, positive margin utilities, but wit
margin-top: -0.25rem !important;
}
```

## Gap
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should move Negative margin and Horizontal centering to an h2?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Opted for another organization to separate margin and padding from gap, since the two behave differently.

@XhmikosR XhmikosR merged commit 649e525 into main Nov 8, 2020
@XhmikosR XhmikosR deleted the gap-utils branch November 8, 2020 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants