Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Form file docs and overrides #32058

Merged
merged 2 commits into from
Nov 3, 2020
Merged

Form file docs and overrides #32058

merged 2 commits into from
Nov 3, 2020

Conversation

ffoodd
Copy link
Member

@ffoodd ffoodd commented Nov 3, 2020

  1. ensure file input have labels in input-groups doc
  2. reuse $form-file-button-bg for $form-file-button-hover-bg to ease override.

@ffoodd ffoodd requested a review from a team as a code owner November 3, 2020 16:48
mdo
mdo approved these changes Nov 3, 2020
View reviewed changes
Copy link
Member

@mdo mdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

MartijnCuppens
MartijnCuppens approved these changes Nov 3, 2020
View reviewed changes
Copy link
Member

@MartijnCuppens MartijnCuppens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Superb

@MartijnCuppens MartijnCuppens merged commit 230a41f into main Nov 3, 2020
@MartijnCuppens MartijnCuppens deleted the main-fod-docs-file-group branch November 3, 2020 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MartijnCuppens MartijnCuppens MartijnCuppens approved these changes

@mdo mdo mdo approved these changes

Assignees
No one assigned
Labels
accessibility docs v5
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ffoodd @mdo @MartijnCuppens