Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests: tweak Jasmine usage #32046

Merged
merged 1 commit into from
Nov 2, 2020
Merged

tests: tweak Jasmine usage #32046

merged 1 commit into from
Nov 2, 2020

Conversation

XhmikosR
Copy link
Member

@XhmikosR XhmikosR commented Nov 2, 2020

Notes:

  1. I think I'd prefer if we could make the rules throw an error instead of a warning, but I can't find an easy way to do it so we'd need to specify all the rules we want and set them as errors
  2. jasmine/expect-single-argument has false warnings with expect().nothing()
  3. jasmine/prefer-toHaveBeenCalledWith would be nice to have AFAICT, but it would need more code changes so I disabled it for now

After #32043 this branch should have zero warnings.

@XhmikosR
tests: tweak Jasmine usage
509f48b 
* jasmine/expect-matcher
* jasmine/prefer-jasmine-matcher

Found with `eslint-plugin-jasmine`
@XhmikosR XhmikosR marked this pull request as ready for review November 2, 2020 14:10
@XhmikosR XhmikosR requested a review from a team as a code owner November 2, 2020 14:10
@XhmikosR XhmikosR changed the title tests: add eslint-plugin-jasmine tests: tweak Jasmine usage Nov 2, 2020
@XhmikosR XhmikosR merged commit c9f8fa4 into main Nov 2, 2020
@XhmikosR XhmikosR deleted the main-xmr-eslint-jasmine branch November 2, 2020 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Johann-S Johann-S Johann-S approved these changes

Assignees
No one assigned
Labels
js tests v5
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@XhmikosR @Johann-S