Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(forms): change inline custom radio name #31936

Merged
merged 1 commit into from
Oct 19, 2020
Merged

docs(forms): change inline custom radio name #31936

merged 1 commit into from
Oct 19, 2020

Conversation

julien-deramond
Copy link
Member

Using the name "customRadioInline1" is confusing because it is also used by id/for for the first custom radio.

As we can see in the previous example of the documentation (https://getbootstrap.com/docs/4.5/components/forms/#radios), we have customRadio and not customRadio1.

Note: the documentation in v5 is correct, it uses "inlineRadioOptions":

<div class="form-check form-check-inline">
  <input class="form-check-input" type="radio" name="inlineRadioOptions" id="inlineRadio1" value="option1">
  <label class="form-check-label" for="inlineRadio1">1</label>
</div>
<div class="form-check form-check-inline">
  <input class="form-check-input" type="radio" name="inlineRadioOptions" id="inlineRadio2" value="option2">
  <label class="form-check-label" for="inlineRadio2">2</label>
</div>
<div class="form-check form-check-inline">
  <input class="form-check-input" type="radio" name="inlineRadioOptions" id="inlineRadio3" value="option3" disabled>
  <label class="form-check-label" for="inlineRadio3">3 (disabled)</label>
</div>

@patrickhlauke
Copy link
Member

Yup, good catch, and agree this avoids confusion

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants