-
-
Notifications
You must be signed in to change notification settings - Fork 78.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Apply smooth-scroll when prefers-reduced-motion: no-preference
#31877
Conversation
i'd be in favour of this |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can dig!
We'll want to mention this in the Migration guide, and perhaps add something else in our docs about this. |
6af6aff
to
9c2fdbd
Compare
Added a mention in our accessibility page, and introduced a reboot section in the migration guide for alpha3. |
On single-page applications, the effect is really jarring when using client-side navigation, which scrolls to the top of a page after a page load. Is there a way to disable this effect? Using
didn't seem to work. |
@andrehsu Please open an issue instead of reviving a closed pull request. |
@andrehsu indeed it is and it should not be the default. When using The solution or workaround I've found is to explicitly set this to
Also, I'm not going to create a new issue for this because reviving an old one is how those come across this defect will be able to better find context regarding the bug, it is also linked in documentation. |
After watching @mmatuzo's talk "Writing even more CSS with accessibility in mind", I wanted to suggest optionnal smooth scroll.
I saw #24889 but it's kinda outdated, and with the support of
prefers-reduced-motion
it's more robust now.Very simple and lightweight PR so feel free to discard it if you think it's still not valuable.