Check for data-interval on the first slide of carousel - v4 #31820
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XhmikosR
reviewed
Oct 2, 2020
mitchellfyi
force-pushed
the
carousel-data-bug-v4
branch
from
116c2a7
to
fa9c367
Compare
|
Waiting on feedback from V5 PR: #31818 |
Johann-S
reviewed
Oct 5, 2020
js/src/carousel.js
Outdated
| @@ -492,6 +503,9 @@ class Carousel { | |||
| $(this._element).trigger(slidEvent) | |||
| } | |||
|
|
|||
| // does not wait for the transition to complete | |||
| this._activeElement = nextElement | |||
There was a problem hiding this comment.
Can you explain this change please?
There was a problem hiding this comment.
this PR is currently out of date (so I reverted it to draft). See #31818
|
@mitchellbryson can you bring this up to par with your main PR and reopen it please? |
|
@mitchellbryson friendly ping :) This is currently the only thing pending in our 4.6.0 project |
|
@XhmikosR sorry for the delay, I'll get on it later this week. |
|
Thanks @mitchellbryson, I really appreciate your help and sticking with us ❤ I'm going to merge this since I tested manually and it seems to do the job (and the diff LGTM anyway). |
XhmikosR
approved these changes
Nov 12, 2020
XhmikosR
changed the title
|
no worries @XhmikosR, thanks for your help getting it through! |
This was referenced Mar 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When starting a cycle for a carousel, it only checks for a default interval, and not an interval defined on the slide element via data props. This adds a check in before creating the interval to move to the next slide.
Fixes #31716