Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update bs-table shortcode #31803

Merged
merged 6 commits into from
Oct 22, 2020
Merged

Update bs-table shortcode #31803

merged 6 commits into from
Oct 22, 2020

Conversation

XhmikosR
Copy link
Member

@XhmikosR XhmikosR commented Oct 1, 2020

Preview: https://deploy-preview-31803--twbs-bootstrap.netlify.app/docs/5.0/customize/options/

BTW this reminds me, shouldn't we make all tables responsive? Should be easy with this shortcode. WIP branch: https://github.com/twbs/bootstrap/compare/main-xmr-hugo-bs-table-responsive

@mdo
Copy link
Member

mdo commented Oct 1, 2020

Yeah, I think all tables should be responsive by default.

@XhmikosR XhmikosR mentioned this pull request Oct 2, 2020
3 tasks
@XhmikosR XhmikosR marked this pull request as ready for review October 2, 2020 12:16
@XhmikosR XhmikosR requested a review from mdo October 5, 2020 06:05
@mdo
Copy link
Member

mdo commented Oct 21, 2020

@XhmikosR Want to open a new PR for that responsiveness by default?

@XhmikosR
Copy link
Member Author

Yup, I'll take care of it on your other branch where you convert all the tables to Markdown.

@XhmikosR XhmikosR merged commit afc0e83 into main Oct 22, 2020
@XhmikosR XhmikosR deleted the main-xmr-hugo-bs-table branch October 22, 2020 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants