-
-
Notifications
You must be signed in to change notification settings - Fork 78.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to dart-sass #31728
Merged
Merged
Switch to dart-sass #31728
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XhmikosR
force-pushed
the
main-xmr-dart-sass
branch
2 times, most recently
from
September 23, 2020 13:12
e3fae53
to
34d1e1b
Compare
XhmikosR
force-pushed
the
main-xmr-dart-sass
branch
from
September 25, 2020 14:55
34d1e1b
to
2798f6c
Compare
XhmikosR
force-pushed
the
main-xmr-dart-sass
branch
3 times, most recently
from
October 9, 2020 05:05
ea470a0
to
0172d84
Compare
XhmikosR
force-pushed
the
main-xmr-dart-sass
branch
from
October 19, 2020 09:24
0172d84
to
ff5d0e2
Compare
XhmikosR
force-pushed
the
main-xmr-dart-sass
branch
from
October 28, 2020 06:41
ff5d0e2
to
c327cc0
Compare
mdo
approved these changes
Oct 28, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pre-approving for when this comes up for review.
node-sass is now deprecated
This is so that we get the same behavior for our minified files since dart-sass doesn't have a precision option and defaults to 10.
XhmikosR
force-pushed
the
main-xmr-dart-sass
branch
2 times, most recently
from
October 29, 2020 07:36
98cd0ee
to
4a75759
Compare
Let's land it as is and we can always revisit the clean-css options later. BTW we could also ask upstream for the output discrepancies and if they can do something about it, like with sorting grouped selectors. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is something we've been discussing internally for some time now.
Things to note:
@charset "UTF-8";
. Not the end of the world, but it is something to note. Also, note that there's a--no-charset
flag, but then this could be dangerous since we do have Unicode characters, so we better not use it@twbs/css-review for discussion
sources
propertyRefs #29853