-
-
Notifications
You must be signed in to change notification settings - Fork 78.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Sass variable for CSS variable prefix #31684
Conversation
We may invert your suggestion too, adding the dash if a string is set—here's a SassMeister. Not sure if it's better or not, just another possible way :) |
I'm ok with the current implementation. We'll need the prefix in other files like https://github.com/twbs/bootstrap/blob/main/scss/_tables.scss too, not sure if there are any other files (read: too lazy to look it up 😄) |
Good point @MartijnCuppens, might undo the last change here and keep it with the |
6512cae
to
b5f5c24
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Just a reminder (mostly for myself since I usually go on a merging spree 😁) some PRs target a next release like alpha3. |
@mdo this needs a rebase |
fe138a4
to
a531ec5
Compare
This comment was marked as spam.
This comment was marked as spam.
* Add Sass variable for CSS variable prefix * Update other --bs-* var instances
Suggestion from @8nix at #26596 (comment).
Question though: should we include the trailing
-
in the prefix variable? Thinking we either do this, or detect if it'snil
and remove the dash. Leaning towards the former and requiring that we include it.Thoughts @twbs/css-review?