Don't wrap the code snippets in our docs #31679
Conversation
|
I must be blind, but I don't see any difference? |
|
have to admit i'm not seeing it either, unless i'm not looking at the right place? e.g. comparing the second code block on, say, https://deploy-preview-31679--twbs-bootstrap.netlify.app/docs/5.0/components/button-group/#button-toolbar vs https://v5.getbootstrap.com/docs/5.0/components/button-group/#button-toolbar i see no difference (both bring up horizontal scrollbar?) |
|
This does have an affect. See the difference in this page:
Difference is most clear under the JS sections. Before:
After:
|
|
It still looks the same for me with Firefox 82.0 and Chrome 86 on Windows :/ What is your window dimensions and browser? |
|
Same here, no change on both Firefox and Chromium on Ubuntu. |
|
this seems to be a Safari/macOS issue only (even Chrome/macOS currently already does the scrollbar on the live v5 docs). but can confirm now that I can see what @mdo described above, and this change indeed forces Safari to behave as intended. (for reference/clarification: i just fired up my Macbook and tried it in Safari. happens at all window sizes, so not just tied to viewport or anything like that) |
|
OK, that makes sense since I don't own any Apple devices myself 😛 So, assuming this does not affect any other browsers and fixes the issue on Safari, it should be good to go, right? |
yup, i'd say so |
Bringing back no wrapping in our code snippets. This helps keep pages and doc snippets a little shorter on our longer pages. Found myself hitting wrapped lines with only a few characters on a new line.
Only affects our docs.
Preview: https://deploy-preview-31679--twbs-bootstrap.netlify.app/