Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scrollspy keyboard access in docs #31578

Merged
merged 1 commit into from
Sep 15, 2020
Merged

Scrollspy keyboard access in docs #31578

merged 1 commit into from
Sep 15, 2020

Conversation

ffoodd
Copy link
Member

@ffoodd ffoodd commented Sep 2, 2020

Mention using tabindex="0" on scrollable areas and apply it in our examples, to ensure keyboard access as stated in axe-core and explained by Heydon Pickering in its inclusive components (eg. "Content Slider").

@XhmikosR
Copy link
Member

@patrickhlauke LGTY?

- Anchors (`<a>`) are required and must point to an element with that `id`.

When successfully implemented, your nav or list group will update accordingly, moving the `.active` class from one item to the next based on their associated targets.

{{< callout >}}
### Spying on elements other than the `<body>`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd say this is more a quick tip on "Scrollable containers" - not specific to spying

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My understanding is:

  1. if you're not spying body, you'll have a scrollable container,
  2. if we mention "scrollable containers", body is concerned.

I'm not sure how I should reword this, I may be misunderstanding both words and concepts here.

Copy link
Member

@patrickhlauke patrickhlauke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from the tiny change in heading, it looks good

@patrickhlauke
Copy link
Member

patrickhlauke commented Sep 15, 2020

my point is: this isn't about spying per se. the tip is in general about how to make a proper div or whatever that works as a scrollable container and is keyboard accessible. the "spying" bit is incidental. (and i don't think that this would confuse folks with <body>...but if you think it would, disambiguate in the first sentence "If you're using a <div> or similar element as a scrollable container")

@ffoodd
Copy link
Member Author

ffoodd commented Sep 15, 2020

@patrickhlauke I reworded things a bit. Is that better?

@patrickhlauke
Copy link
Member

:shipit:

@XhmikosR XhmikosR merged commit 390ce24 into main Sep 15, 2020
@XhmikosR XhmikosR deleted the main-fod-docs-scrollspy branch September 15, 2020 15:29
olsza pushed a commit to olsza/bootstrap that referenced this pull request Oct 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants