-
-
Notifications
You must be signed in to change notification settings - Fork 78.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Scrollspy keyboard access in docs #31578
Conversation
5710803
to
3bda47e
Compare
@patrickhlauke LGTY? |
- Anchors (`<a>`) are required and must point to an element with that `id`. | ||
|
||
When successfully implemented, your nav or list group will update accordingly, moving the `.active` class from one item to the next based on their associated targets. | ||
|
||
{{< callout >}} | ||
### Spying on elements other than the `<body>` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd say this is more a quick tip on "Scrollable containers" - not specific to spying
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My understanding is:
- if you're not spying
body
, you'll have a scrollable container, - if we mention "scrollable containers",
body
is concerned.
I'm not sure how I should reword this, I may be misunderstanding both words and concepts here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apart from the tiny change in heading, it looks good
my point is: this isn't about spying per se. the tip is in general about how to make a proper div or whatever that works as a scrollable container and is keyboard accessible. the "spying" bit is incidental. (and i don't think that this would confuse folks with |
0c45500
to
ac5bb49
Compare
@patrickhlauke I reworded things a bit. Is that better? |
Mention using
tabindex="0"
on scrollable areas and apply it in our examples, to ensure keyboard access as stated in axe-core and explained by Heydon Pickering in its inclusive components (eg. "Content Slider").