Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding overflow visible and scroll as utilities #31343

Merged
merged 2 commits into from
Oct 13, 2020
Merged

Adding overflow visible and scroll as utilities #31343

merged 2 commits into from
Oct 13, 2020

Conversation

gauravbehere
Copy link
Contributor

@gauravbehere gauravbehere commented Jul 21, 2020 •
edited by XhmikosR
Loading

  • Adding overflow visible & scroll as a utility.

Demo

image

How does this fix the issue?

image

Preview: https://deploy-preview-31343--twbs-bootstrap.netlify.app/docs/5.0/utilities/overflow/

@gauravbehere gauravbehere requested a review from a team as a code owner July 21, 2020 08:28
@techboyg5
Copy link

How about adding overflow-scroll as well? That completes the overflow family!

mdo
mdo approved these changes Sep 15, 2020
View reviewed changes
Copy link
Member

@mdo mdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved for Alpha 3.

@XhmikosR XhmikosR changed the title Adding overflow visible as util Adding overflow visible and scroll as utilities Sep 29, 2020
@XhmikosR
Copy link
Member

Maybe we should add margin is some viewports in bd-example.d-md-flex? Also, it seems the other examples don't have the margin utilities.

I'd say it needs some tweaking before merging @mdo.

@XhmikosR XhmikosR merged commit 0205a01 into twbs:main Oct 13, 2020
@XhmikosR XhmikosR added the v5 label Oct 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdo mdo mdo approved these changes

Assignees
No one assigned
Labels
css feature v5
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gauravbehere @techboyg5 @XhmikosR @mdo