Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: mention our bundle file clearly. #31300

Merged
merged 5 commits into from
Sep 15, 2020
Merged

docs: mention our bundle file clearly. #31300

merged 5 commits into from
Sep 15, 2020

Conversation

XhmikosR
Copy link
Member

@XhmikosR XhmikosR commented Jul 14, 2020

Note that we are using the bundle file already in our docs since 787441d.

Preview: https://deploy-preview-31300--twbs-bootstrap.netlify.app/

@XhmikosR XhmikosR marked this pull request as draft July 14, 2020 18:47
@mdo
Copy link
Member

mdo commented Aug 3, 2020

One copy tweak, and then okay to open for review?

@XhmikosR XhmikosR marked this pull request as ready for review September 10, 2020 10:28
@mdo
Copy link
Member

mdo commented Sep 14, 2020

Pushed some changes and rebased.

  • Homepage now only shows the JS bundle option. Showing options on our homepage will just trip people up. Let's streamline there, and expand on inner docs pages.
  • Intro page has been rearranged to clarify the JS quick start options. New headings, rearranged paragraphs, etc.
  • Improved labels and commented out the second JS option in the starter template.

Should be good to go after another review from @XhmikosR.

@XhmikosR
Copy link
Member Author

Perfect, thanks!

@XhmikosR
Copy link
Member Author

BTW backporting might be tricky, not sure when I'll get to do it.

@XhmikosR XhmikosR merged commit 5122429 into main Sep 15, 2020
@XhmikosR XhmikosR deleted the main-xmr-docs-bundle branch September 15, 2020 05:57
@XhmikosR
Copy link
Member Author

@mdo this is a little tricky to backport, if you could take a stab at it, I'd appreciate it 🙂

@mdo mdo mentioned this pull request Sep 28, 2020
XhmikosR added a commit that referenced this pull request Sep 28, 2020
* Manually backport JS bundle guidance

Co-authored-by: XhmikosR <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants