v5: Updated About and Brand pages #31248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
xref #31092 (it closes the core issue there, but the question about the "if it’s purple, it’s representative of Bootstrap" bit still remains currently) |
|
A couple of comments:
|
|
Are we sure want to backport it? I thought only v5+ would use the new logos. |
|
This should be good to go now. |
|
@mdo it seems we need
|
|
Or the width/height attributes are currently wrong :) |
|
Fixed that @XhmikosR :). |
|
Perfect, I'll rebase the branch later and merge it :) |
XhmikosR
approved these changes
Sep 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #31144, fixes #31092.
Updated this to remove some intended changes. This should be good to go now.
Preview: https://deploy-preview-31248--twbs-bootstrap.netlify.app/docs/5.0/about/brand/