Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix scrollable modal #31151

Merged
merged 2 commits into from
Jun 25, 2020
Merged

Fix scrollable modal #31151

merged 2 commits into from
Jun 25, 2020

Conversation

ysds
Copy link
Member

@ysds ysds commented Jun 23, 2020 •
edited by XhmikosR
Loading

@ysds ysds requested a review from a team June 23, 2020 04:06
mdo
mdo approved these changes Jun 25, 2020
View reviewed changes
Copy link
Member

@mdo mdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks!

@XhmikosR XhmikosR merged commit c140347 into main Jun 25, 2020
@XhmikosR XhmikosR deleted the main-ysds-scrollable-modal-fix branch June 25, 2020 06:43
@Johann-S Johann-S mentioned this pull request Aug 11, 2020
Closed
olsza pushed a commit to olsza/bootstrap that referenced this pull request Oct 3, 2020
@ysds @XhmikosR @olsza
Fix scrollable modal (twbs#31151)
0850447 
Co-authored-by: XhmikosR <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdo mdo mdo approved these changes

Assignees
No one assigned
Labels
css no-backport-to-v4 v5
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

modal dialog scrollable isn't working in v5 alpha, need some css improvement
3 participants
@ysds @mdo @XhmikosR