-
-
Notifications
You must be signed in to change notification settings - Fork 78.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs: screen reader helper/visibility utility tweaks #31133
Conversation
meta-question: what's the cut-off between something being a "helper" and something being a "utility"? |
To be more representative of the fact that these are not necessarily "screen reader" specific, but actually apply to assistive technologies in general (and also things like Alexa/Siri/etc). Goes hand-in-hand with #31133
Related, the proposed PR to actually rename the classes/mixins as well #31139 |
Note that we should focus to v5 and leave v4 in maintenance mode. We don't need to backport everything. Also, this needs to be handled carefully in v4 with a redirect. |
ok, there's probably little point in backporting just this bit. focusing on v5 makes sense. |
@XhmikosR should this also have an |
Doesn't hurt but maybe we don't need to, since it's still an alpha. I'll add a note to revisit the aliases later. |
* Rename `sr-only`/`sr-only-focusable` To be more representative of the fact that these are not necessarily "screen reader" specific, but actually apply to assistive technologies in general (and also things like Alexa/Siri/etc). Goes hand-in-hand with #31133 Co-authored-by: XhmikosR <[email protected]>
"screen readers" is quite reductive, as there are other assistive technologies. content hidden this way is even announced by things like Alexa/Siri etc, so it's not so much just "screen readers". in the long run, we may even consider changing the actual classnames (maybe `.visually-hidden` / `.visually-hidden-focusable`, though admittedly that's a bit verbose). also includes a tiny tweak to layout.md to generalise the note about using `.sr-only`
c58bed8
to
f7053ae
Compare
Generally speaking, utilities are single property-value pairings and helpers are shortcuts or snippets. |
any chance of a review please? ;) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but I want @mdo to also review
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* Rename `sr-only`/`sr-only-focusable` To be more representative of the fact that these are not necessarily "screen reader" specific, but actually apply to assistive technologies in general (and also things like Alexa/Siri/etc). Goes hand-in-hand with twbs#31133 Co-authored-by: XhmikosR <[email protected]>
.visually-hidden
/.visually-hidden-focusable
or similar?).invisible
hides stuff from AT