Update migration.md #31122
Merged
Update migration.md #31122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hi Thanks |
NN means we forgot to change these, hence this PR :) I plan to add more info in migration page, but I'll probably need some help @mdo about the |
* Add a new v5.0.0-alpha2 section * Add missing Browser version in v5.0.0-alpha1
XhmikosR
commented
Jun 25, 2020
site/content/docs/5.0/migration.md
Outdated
|
|
||
| We've updated the color system that powers Bootstrap to improve color contrast and provide a much more extensive set of colors. | ||
|
|
||
| - Updated blue and pink base colors (`-500`) to ensure AA contrast. | ||
| - Updated blue and pink base colors (`-500`) to ensure WCAG 2 AA contrast. |
There was a problem hiding this comment.
@patrickhlauke should this be 2.1?
There was a problem hiding this comment.
yes would make sense to change to 2.1
There was a problem hiding this comment.
(technically it's not incorrect, as 2.1 only extends 2.0 so the contrast requirement is unchanged/inherited in 2.1, but still)
|
Can I get an approval please? We can leave the TODO for another time, as long as we do it before beta/stable |
ffoodd
approved these changes
Jul 1, 2020
olsza
pushed a commit
to olsza/bootstrap
that referenced
this pull request
Oct 3, 2020
* Add a new v5.0.0-alpha2 section * Add missing Browser versions from v5.0.0-alpha1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Draft because I want to update a couple more things like the supported browsers.
mainbranchTodoin migrationPreview: https://deploy-preview-31122--twbs-bootstrap.netlify.app/docs/5.0/migration/