Docs: clarify rationale for button group on links #31071
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- clarify that putting links in a button group is, in essence, an alternative to using the navigation component (and cross-reference it) - remove the non-sequitur about using `.active`...that's irrelevant here, as it's already mentioned in the docs page for `.btn`. otherwise, this would then also need the whole extra explanation about conveying meaning with `aria-current` etc, which is already covered in ample detail in the navs page
MartijnCuppens
approved these changes
Jun 17, 2020
|
@patrickhlauke this needs to be backported manually, I don't even know if we have those snippets in v4-dev. |
|
This doesn't seem to apply to v4-dev. If you still think it does, re-add it in the v4-next project and make a PR against v4-dev. |
|
ah you're right, could have sworn v4 also had a link button group example, but i must have dreamt it |
olsza
pushed a commit
to olsza/bootstrap
that referenced
this pull request
Oct 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.active...that's irrelevant here, as it's already mentioned in the docs page for.btn. otherwise, this would then also need the whole extra explanation about conveying meaning witharia-currentetc, which is already covered in ample detail in the navs page