Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Stack Overflow tag #31062

Merged
merged 4 commits into from
Jun 18, 2020
Merged

Fix Stack Overflow tag #31062

merged 4 commits into from
Jun 18, 2020

Conversation

cstuder
Copy link
Contributor

@cstuder cstuder commented Jun 17, 2020

Minor documentation fix.

@XhmikosR XhmikosR requested a review from mdo June 17, 2020 06:01
XhmikosR
XhmikosR previously approved these changes Jun 18, 2020
View reviewed changes
@XhmikosR
Copy link
Member

Actually, @cstuder can you update README.md too please?

@XhmikosR XhmikosR self-requested a review June 18, 2020 06:59
@XhmikosR
Copy link
Member

It seems we have more places:

Search "bootstrap-4" (8 hits in 4 files)
  E:\Downloads\Internet Downloads\bootstrap-main\bootstrap-main\.github\CONTRIBUTING.md (2 hits)
	Line 22:   Overflow ([`bootstrap-4`](https://stackoverflow.com/questions/tagged/bootstrap-4) tag),
	Line 22:   Overflow ([`bootstrap-4`](https://stackoverflow.com/questions/tagged/bootstrap-4) tag),
  E:\Downloads\Internet Downloads\bootstrap-main\bootstrap-main\.github\SUPPORT.md (2 hits)
	Line 11: - Ask and explore Stack Overflow with the [`bootstrap-4`](https://stackoverflow.com/questions/tagged/bootstrap-4) tag.
	Line 11: - Ask and explore Stack Overflow with the [`bootstrap-4`](https://stackoverflow.com/questions/tagged/bootstrap-4) tag.
  E:\Downloads\Internet Downloads\bootstrap-main\bootstrap-main\site\content\docs\5.0\getting-started\introduction.md (2 hits)
	Line 125: - Implementation help may be found at Stack Overflow (tagged [`bootstrap-4`](https://stackoverflow.com/questions/tagged/bootstrap-4)).
	Line 125: - Implementation help may be found at Stack Overflow (tagged [`bootstrap-4`](https://stackoverflow.com/questions/tagged/bootstrap-4)).
  E:\Downloads\Internet Downloads\bootstrap-main\bootstrap-main\README.md (2 hits)
	Line 164: - Implementation help may be found at Stack Overflow (tagged [`bootstrap-4`](https://stackoverflow.com/questions/tagged/bootstrap-4)).
	Line 164: - Implementation help may be found at Stack Overflow (tagged [`bootstrap-4`](https://stackoverflow.com/questions/tagged/bootstrap-4)).

@XhmikosR XhmikosR added the meta label Jun 18, 2020
@cstuder
Copy link
Contributor Author

cstuder commented Jun 18, 2020

Will do, didn't think to check other files too.

@cstuder
Copy link
Contributor Author

cstuder commented Jun 18, 2020

@XhmikosR Done. Please re-review.

XhmikosR
XhmikosR approved these changes Jun 18, 2020
View reviewed changes
Copy link
Member

@XhmikosR XhmikosR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@XhmikosR XhmikosR changed the title Introduction: Fixes missing version increase Fix Stack Overflow tag Jun 18, 2020
@XhmikosR XhmikosR merged commit 3a61e1a into twbs:main Jun 18, 2020
@cstuder cstuder deleted the patch-1 branch June 18, 2020 11:24
olsza pushed a commit to olsza/bootstrap that referenced this pull request Oct 3, 2020
@cstuder @olsza
Fix Stack Overflow tag (twbs#31062)
e5e6e78
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XhmikosR XhmikosR XhmikosR approved these changes

@mdo mdo Awaiting requested review from mdo

Assignees
No one assigned
Labels
docs meta v5
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cstuder @XhmikosR