Floating labels improvements #30966
Merged
Floating labels improvements #30966
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdo
previously approved these changes
Jun 16, 2020
|
Testing this on Netlify in IE11 isn't super clear to me... that's likely because I'm looking at v5's code that doesn't support IE at all anymore, but the example doesn't work there anymore. Signed off on this earlier, but going to retract and punt to alpha 2 to confirm a few things first <3. |
|
Could be because the branch was behind, have another try @mdo. Note that this PR is for Edge not IE since IE is not supported on v5. |
XhmikosR
requested changes
Jun 22, 2020
site/content/docs/5.0/examples/floating-labels/floating-labels.css
Outdated
Show resolved
Hide resolved
ffoodd
force-pushed
the
master-fod-Edge-floating-labels
branch
from
160606f
to
d9c1ba1
Compare
XhmikosR
approved these changes
Jun 24, 2020
XhmikosR
pushed a commit
that referenced
this pull request
Jun 24, 2020
* docs(example): floating-labels' better Edge fallback * docs(example): refactor floating-labels' CSS
XhmikosR
pushed a commit
that referenced
this pull request
Jun 24, 2020
* docs(example): floating-labels' better Edge fallback * docs(example): refactor floating-labels' CSS
mdo
added a commit
that referenced
this pull request
Sep 23, 2020
XhmikosR
pushed a commit
that referenced
this pull request
Oct 1, 2020
olsza
pushed a commit
to olsza/bootstrap
that referenced
this pull request
Oct 3, 2020
* docs(example): floating-labels' better Edge fallback * docs(example): refactor floating-labels' CSS
mdo
added a commit
that referenced
this pull request
Oct 20, 2020
mdo
added a commit
that referenced
this pull request
Oct 26, 2020
mdo
added a commit
that referenced
this pull request
Oct 28, 2020
* v5: Promote floating labels example to component - Adds new .form-floating - Stubs out basics of a docs page - Removes existing Example * Update floating labels to support .form-select, make inputs and selects more consistent - To do this, I made the .form-control and .form-select consistent in min-height vs height - Removed some unused variables now - Updated -color to be the -color because I don't know why this was any different before - Update page to include some examples for layout, validation, and value - Rewrite styles to not modify padding, but instead transform and opacity * Streamline and bulletproof some things - Apply some optimizations from code review - Removed unecessary properties from the label - Add some comments for what properties are required - Move from fixed height for labels to height 100% so we can support textareas - Improve docs a little bit, add ToC * Move some values to variables, switch from scaling font-size to scale, update transforms * Bring over changes from #30966 and add to them to tighten things up * Delete the now unused example images * Fix typo * Allowlist the calc function * Add transform-origin, update transform values * Test out autofill fix * Fix linter issue * Mention it in the migration guide * Bump bundlesize * Add one more variable per review * Shave .25rem off the height Co-authored-by: XhmikosR <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Next to #30965 — for v5 concerns.
display: noneand simply switching to flex reversed layout…Preview: https://deploy-preview-30966--twbs-bootstrap.netlify.app/docs/5.0/examples/floating-labels/