Fix tooltip when hovering a child element (delegateTarget)
#30928
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tkrotoff
commented
May 29, 2020
| @@ -81,6 +81,17 @@ And with custom HTML added: | |||
| </button> | |||
| {{< /highlight >}} | |||
|
|
|||
| With an SVG: | |||
There was a problem hiding this comment.
Allows to test/demonstrate inside documentation, should be done another way I guess.
Without the delegateTarget fix, it does not show the tooltip when hovering and crashes when mouse leaving.
tkrotoff
commented
May 29, 2020
|
|
||
| spyOn(tooltip, 'show') | ||
|
|
||
| tooltipEl.querySelector('rect').dispatchEvent(createEvent('mouseover', { bubbles: true })) |
There was a problem hiding this comment.
bubbles: true is important here, otherwise it won't work
tkrotoff
force-pushed
the
tooltip-delegateTarget
branch
4 times, most recently
from
67a9192
to
b544f08
Compare
tkrotoff
force-pushed
the
tooltip-delegateTarget
branch
from
b544f08
to
0cf873d
Compare
tkrotoff
force-pushed
the
tooltip-delegateTarget
branch
from
0cf873d
to
308fb32
Compare
|
I tried this fix, it does fix that bug |
XhmikosR
changed the title
delegateTarget)
XhmikosR
changed the title
delegateTarget)delegateTarget)
olsza
pushed a commit
to olsza/bootstrap
that referenced
this pull request
Oct 3, 2020
…0928) Co-authored-by: XhmikosR <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
v5
See #30597 (comment) & #30597 (comment)
Before (master):
After (this branch):
Preview: https://deploy-preview-30928--twbs-bootstrap.netlify.app/docs/5.0/components/tooltips/#examples
Fixes #31080