v4: Update docs callout for responsive SVG images #30809
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Turns out this applies to IE11 as well as IE10, so this clarifies the docs callout. Closes #25242.
|
Didn't know of this section. For SVGs, couldn't our reboot use something like AFAIC this PR looks good 🙂 |
ffoodd
approved these changes
May 14, 2020
If I recall correctly, this could have unintended consequences for perfectly sized SVGs. Opt-in has seemed like the best approach here, and we don't ned this in v5 at all, so I'm okay leaving nearly as-is. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns out this applies to IE11 as well as IE10, so this clarifies the docs callout.
Closes #25242.