karma: stop excluding polyfill.js from istanbul #30740
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't understand why do we need to remove that 🤔 we still have some polyfills |
|
It seems the custom coverage thresholds are no longer needed. |
|
oh yeah saw that on Coveralls, how is it possible ? 🤔 |
|
We have removed some polyfills. |
|
Actually, Coveralls does not show polyfill.js at all. We should investigate why this happens. |
XhmikosR
force-pushed
the
master-xmr-js-karma-cover
branch
from
c1e15d3
to
4069166
Compare
XhmikosR
force-pushed
the
master-xmr-js-karma-cover
branch
from
4069166
to
d98c317
Compare
|
yep LGTM 👍 and indeed we should check if we still need those polyfills |
Johann-S
approved these changes
Nov 1, 2020
XhmikosR
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.