Add .dropdown-menu-dark #30171
Add .dropdown-menu-dark #30171
Conversation
|
I'm a bit worried that once we're adding some dark components, people will keep asking for support for other elements (eg. modals, pagination (which I declined in the past, #29892), form elements, ect... ) Once we switch to CSS variables, it 'll be way easier to colorize components. |
|
Yeah, I agree on that concern, but we can still say no to most. I mostly wanted to do this because of how prominent our dark navbar component is. Completing the style there and connecting the two components (navbar and dropdown) makes a lot of sense to me. The rest, I'm not as sold on, though we might as well discuss our options further beyond this. |
|
Ok, fine by me. Could you also switch the dropdowns of the dark navbars then (make sure to tackle the examples too)? |
Know I Any aversions to merging as-is without further examples or docs examples? |
Now that we have CSS custom properties, this might be a good use case to use them. I think in we 'll need to update our other components to CSS custom properties (where suitable), adding this like might cause double work. |
|
Thinking I'll leave this as-is for now and then come back in minor releases to CSS-variable-ify everything. Thoughts on that approach @MartijnCuppens? |
mdo
force-pushed
the
dropdown-menu-dark
branch
from
e13be2e
to
c5fc9e1
Compare
|
I like it, I just don't know how we are going to proceed with dark components for all components in the future, but we'll discuss it later :) |
* Add .dropdown-menu-dark * Match background color to navbar dark * Update docs to include a navbar example * Update dropdowns.md Co-authored-by: XhmikosR <[email protected]>
Fixes #30105.
Preview: https://deploy-preview-30171--twbs-bootstrap.netlify.app/docs/5.0/components/dropdowns/#dark-dropdowns