Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reboot updates #28917

Merged
merged 3 commits into from
Jul 25, 2019
Merged

Reboot updates #28917

merged 3 commits into from
Jul 25, 2019

Conversation

MartijnCuppens
Copy link
Member

@MartijnCuppens MartijnCuppens commented Jun 17, 2019

  • Inherit box-sizing and set box-sizing: border-box; on body
    This makes it possible for 3th party components to use box-sizing: content-box by just applying the box-sizing to the wrapper div.
    Nope: Reboot updates #28917 (comment)
  • Remove unsupported browsers fixes (IE10 & Firefox 39-)
  • More consistent comment blocks
  • Reorganise order of some blocks
  • Add height fix for date/month/week/time inputs (Temporal inputs are 2px taller than other textual inputs in Chrome #18842, this was already fixed by adding a height to form controls, with this change we don't need to set the height anymore)
  • Remove redundant type selectors for some pseudo elements
  • Additional resets and theming options for legend
  • Element theming from _code.scss moved to reboot
  • All input fields now have the same borders

Todo:

  • Merge code page with reboot page

Result: https://deploy-preview-28917--twbs-bootstrap.netlify.com/docs/4.3/content/reboot/

scss/_reboot.scss Outdated Show resolved Hide resolved
scss/_reboot.scss Outdated Show resolved Hide resolved
@MartijnCuppens MartijnCuppens requested a review from a team as a code owner July 13, 2019 08:46
@MartijnCuppens MartijnCuppens force-pushed the master-mc-reboot-update branch 6 times, most recently from 12840b0 to cda30cc Compare July 14, 2019 10:51
@mdo
Copy link
Member

mdo commented Jul 16, 2019

Regarding the box-sizing change: #22872

@mdo
Copy link
Member

mdo commented Jul 21, 2019

Last thing I've noticed here is that if we're moving all those styles to Reboot, we need to move the docs content to the Reboot page as well.

@MartijnCuppens
Copy link
Member Author

I'm not sure what to do with the .pre-scrollable class. It's the only class left in _code.scss and I can't document it on the reboot page since it isn't part of it. Should we leave it as only class on the code page and in _code.scss or is it not worth it and can we drop it?

@ysds
Copy link
Member

ysds commented Jul 25, 2019

I agree to remove the .pre-scrollable. I'm OK remove it in this PR, but I prefer to separate for clarity.

@MartijnCuppens MartijnCuppens mentioned this pull request Jul 25, 2019
1 task
@MartijnCuppens
Copy link
Member Author

I've opened #29135 to drop the class.

MartijnCuppens and others added 2 commits July 25, 2019 19:06
- Remove unsupported browsers fixes
- More consistent comment blocks
- Reorganise order of some blocks
- Add height fix for date/month/week/time inputs (#18842)
- Remove redundant type selectors
- Additional resets and theming options for `legend`
- Add date & color inputs to reboot page
- Use the same borders for text search, text inputs, textareas and date inputs
- Move code styling to reboot
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants