Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed tether requirement for UMD. #20235

Closed
wants to merge 1 commit into from
Closed

Fixed tether requirement for UMD. #20235

wants to merge 1 commit into from

Conversation

neochief
Copy link

@neochief neochief commented Jul 5, 2016

It does not seem possible to use tooltips withing UMD environment because of hard windows.Tether check. I've added proper import of tether, which should eliminate the problem.

@cvrebert
Copy link
Collaborator

cvrebert commented Jul 6, 2016

It's planned to resolve this properly as part of fixing #19017.

@neochief
Copy link
Author

neochief commented Jul 6, 2016

Thanks, I haven't found that one while I was searching for similar issues.

@neochief neochief closed this Jul 6, 2016
@mister-good-deal
Copy link

Hi, got the error using requirejs and a shim declaration for tether requirement.

require.config(
    {
        'paths' : {
            'require'  : 'vendors/require',
            'bootstrap': 'vendors/bootstrap',
            'tether'   : 'vendors/tether',
            'jquery'   : 'vendors/jquery'
        },
        'shim'  : {
            'bootstrap': {
                'deps': ['jquery', 'tether']
            }
        }
    }
);

Is this fix merged in dev branch ? I'm using bower to required bootstrap 4 with

{
    "dependencies": {
        "jquery"         : "^2.2.4",
        "bootstrap"      : "https://github.com/twbs/bootstrap.git#v4-dev",
        "font-awesome"   : "^4.6.3",
        "requirejs"      : "^2.2.0",
        "tether"         : "^1.3.3"
    }
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants