-
-
Notifications
You must be signed in to change notification settings - Fork 78.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add justified navs #18653
Add justified navs #18653
Conversation
} | ||
|
||
.nav-link { | ||
text-align: center; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Properties should be ordered margin-bottom, text-align
border-radius: $border-radius; | ||
} | ||
|
||
.nav-link.active, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Make use of the plain-hover-focus
mixin here.
See
bootstrap/scss/mixins/_hover.scss
Line 27 in 86c0520
@mixin plain-hover-focus { |
@include plain-hover-focus { | ||
border-bottom-color: $nav-tabs-justified-active-link-border-color; | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Line contains trailing whitespace
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Line contains trailing whitespace
I added some justified nav in #21201 via flexbox. |
see: #17723