docs-assets: concatenate and minify all docs files.

[XhmikosR]

See #11976, docs.js has the normal BS banner atm.

[cvrebert]

IMHO, we may want to leave bootstrap.min.js separate, like we do with the CSS.

[cvrebert]

Should probably be docs.min.js

[XhmikosR]

OK thought about it too but left it since customize.js doesn't include "min" either.

[cvrebert]

Honestly, it also ought to be customize.min.js; one of those little things that no one has gotten around to.

[XhmikosR]

Yeah I will change those now. I solved the issue with the CSS so I will add this too.

[XhmikosR]

I plan to combine the CSS too but I haven't finished it yet.

EDIT: I can't make it work right with clean-css' root option. If I use root: '../dist/' I end up with url(C:/Users/xmr/Desktop/bootstrap/dist/fonts/glyphicons-halflings-regular.eot)

[XhmikosR]

@cvrebert: please check now, I updated the PR.

[mdo]

Extra line

[XhmikosR]

Fixed.

[mdo]

I'd prefer to leave the compiled Bootstrap files separated from any built files. Helps ensure consistency across all our docs, examples, etc. We can combine the docs and Pygments CSS though into one file, perhaps manually even.

I don't know how much this really saves us—we have no hosting costs and the loading times aren't that bad right now with things as they are. Mostly what I see is more Grunt tasks.

[XhmikosR]

@mdo: I don't mind leaving bootstrap.css out and concatenate the rest. But we should definitely do this. It's not only about bandwidth from your side; it's about bandwidth from the user's side.

[mdo]

Word, I hear you on the minification at least. I'm curious what the changes in size are though—how much are we gaining (er, losing)?

[XhmikosR]

For the CSS it's around 11KB and -2 HTTP requests.

For the JS it should be bigger but don't have any numbers yet.

[XhmikosR]

@mdo: don't merge this yet. Yet another IE 8 bug with the CSS file size limit. I suppose on the server we won't see the issue since gzip is enabled but I'm currently looking into this.

An alternative way will be to keep 2 CSS files, bootstrap.min.css and pack.min.css. And for consistency we can do this for the JS too.

What do you think?

[XhmikosR]

Turns out it's a bug in clean-css or grunt-contrib-cssmin. I need to investigate this more but when I use noAdvanced: true in cssmin options then it works fine otherwise the resulting CSS isn't parsed right by IE8.

So we still can combine everything when this issue is sorted.

[XhmikosR]

Worked around the issue for the time being by disabling advanced optimizations. Everything seems to work fine here. I also kept bootstrap.min.css and bootstrap.min.js.

BTW, raw-files.js seems redundant now since it's being combined to customize.min.js.

[mdo]

Looking at this again, some more things came to mind.

• Packaging the docs CSS means running a grunt command just to load new CSS changes.
• How does this handle updates to the raw-files.js? That task comes later in the Gruntfile—at first glance, we'd be concatenating and minifying the old version.

I'm all about optimizing, but not if it makes things more cumbersome to work with.

[XhmikosR]

Both can be resolved easily though.

I can have a look tomorrow just give me a couple of hints how you want this addressed.

[XhmikosR]

PR rebased.

@mdo: what exactly you don't like at the moment? You already have to run grunt dist.

The only thing I find pointless is the raw-files.js. But I'd rather leave this to someone else.